fix(plugin-webpack): correctly define the asset relocator base dir

[tjquillan]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Closes #1801 which appears to have been abandoned.

Fixes #1559.

[codecov]

Codecov Report

Merging #2022 (28459da) into master (7e3227b) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2022      +/-   ##
==========================================
+ Coverage   72.65%   72.74%   +0.09%     
==========================================
  Files          74       74              
  Lines        2220     2220              
  Branches      420      420              
==========================================
+ Hits         1613     1615       +2     
- Misses        444      445       +1     
+ Partials      163      160       -3     

Impacted Files	Coverage Δ
packages/plugin/webpack/src/WebpackConfig.ts	97.61% <ø> (+2.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e3227b...28459da. Read the comment docs.

[malept]

This seems reasonable, feel free to write tests for this.

[malept]

FYI the tests are failing on Windows due to differences in how paths are constructed.

[tjquillan]

Thanks for catching that! I pushed a commit that should fix it but I did not have a windows machine to verify.

[malept]

The tests expect the Windows paths' backslashes to be escaped.

[tjquillan]

Am I correct to assume this is what JSON.stringify is doing in assetRelocatorBaseDir?

Edit: Also, sorry for all this hassle.

[malept]

Am I correct to assume this is what JSON.stringify is doing in assetRelocatorBaseDir?

Seems so:

> JSON.stringify('C:\foo')
'"C:\\foo"'

[malept]

Thanks for finishing it up!