Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): add plugin:import/electron to TypeScript ESLint config #2399

Merged
merged 4 commits into from
Jul 23, 2021

Conversation

malept
Copy link
Member

@malept malept commented Jul 23, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

  • Add import/electron settings
  • Update import config to use recommended over errors + warnings
  • Remove redundant settings
  • Add proper test script to the typescript-webpack template module

Closes #2142.

@malept malept force-pushed the fix/template/eslint-import branch from 95a05bd to f378e0c Compare July 23, 2021 17:04
@malept malept force-pushed the fix/template/eslint-import branch from f378e0c to 7c141bd Compare July 23, 2021 17:05
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2399 (7c141bd) into master (4fadec7) will decrease coverage by 2.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2399      +/-   ##
==========================================
- Coverage   75.03%   72.67%   -2.36%     
==========================================
  Files          91       91              
  Lines        2339     2335       -4     
  Branches      437      437              
==========================================
- Hits         1755     1697      -58     
+ Misses        476      473       -3     
- Partials      108      165      +57     
Impacted Files Coverage Δ
packages/api/core/src/api/publish.ts 69.73% <0.00%> (-22.37%) ⬇️
packages/api/core/src/api/start.ts 65.43% <0.00%> (-22.23%) ⬇️
packages/api/core/src/api/install.ts 78.20% <0.00%> (-16.67%) ⬇️
packages/api/core/src/util/rebuild.ts 92.85% <0.00%> (-7.15%) ⬇️
packages/api/core/src/api/make.ts 81.72% <0.00%> (-6.58%) ⬇️
packages/api/core/src/api/init.ts 91.17% <0.00%> (-5.89%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 96.42% <0.00%> (+1.69%) ⬆️
packages/installer/darwin/src/InstallerDarwin.ts 33.33% <0.00%> (+1.75%) ⬆️
packages/maker/base/src/Maker.ts 77.77% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fadec7...7c141bd. Read the comment docs.

@malept malept merged commit f42c962 into master Jul 23, 2021
@malept malept deleted the fix/template/eslint-import branch July 23, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant