Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add support for finding electron for npm 7 workspaces #2446

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

malept
Copy link
Member

@malept malept commented Aug 14, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #2306.

Also does a refactor of the electron version tests for clarity and scoping of test variables. They were kind of in a weird state since we do not run the testsuite for each NODE_INSTALLER anymore.

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #2446 (9104e3d) into master (677cf9d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2446      +/-   ##
==========================================
+ Coverage   75.29%   75.35%   +0.05%     
==========================================
  Files          91       91              
  Lines        2352     2353       +1     
  Branches      441      440       -1     
==========================================
+ Hits         1771     1773       +2     
  Misses        472      472              
+ Partials      109      108       -1     
Impacted Files Coverage Δ
packages/api/core/src/util/electron-version.ts 90.62% <100.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677cf9d...9104e3d. Read the comment docs.

@malept malept merged commit 4c60151 into master Aug 14, 2021
@malept malept deleted the malept/fix/core/npm-workspaces branch August 14, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron-forge does not work with npm workspaces (npm v7)
1 participant