Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unpin electron-notarize #2515

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

malept
Copy link
Member

@malept malept commented Sep 10, 2021

Summarize your changes:

Fixes #2496.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #2515 (ab3220b) into master (73252c3) will increase coverage by 1.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2515      +/-   ##
==========================================
+ Coverage   72.89%   74.78%   +1.89%     
==========================================
  Files          91       91              
  Lines        2365     2368       +3     
  Branches      448      447       -1     
==========================================
+ Hits         1724     1771      +47     
- Misses        471      473       +2     
+ Partials      170      124      -46     
Impacted Files Coverage Δ
packages/maker/base/src/Maker.ts 75.67% <0.00%> (-2.11%) ⬇️
packages/api/core/src/util/upgrade-forge-config.ts 94.73% <0.00%> (-1.70%) ⬇️
packages/installer/darwin/src/InstallerDarwin.ts 33.33% <0.00%> (ø)
packages/api/core/src/api/install.ts 79.48% <0.00%> (+1.28%) ⬆️
packages/api/core/src/api/init.ts 97.56% <0.00%> (+4.87%) ⬆️
packages/api/core/src/util/rebuild.ts 100.00% <0.00%> (+7.14%) ⬆️
packages/api/core/src/api/make.ts 88.00% <0.00%> (+7.19%) ⬆️
packages/api/core/src/api/start.ts 87.65% <0.00%> (+22.22%) ⬆️
packages/api/core/src/api/publish.ts 92.10% <0.00%> (+22.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73252c3...ab3220b. Read the comment docs.

@malept malept merged commit af78353 into master Sep 10, 2021
@malept malept deleted the malept/fix/unpin-electron-notarize branch September 10, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron-notorize hanging, but pinned to old version
1 participant