feat: 🎸 Add packageSourceMaps option to WebpackPluginConfig

[zac-jacobson]

Stop including source maps in a packages application by default.

Add packageSourceMaps to WebpackPluginConfig allow source maps to be included in the packaged application.

✅ Closes: #2573

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Add a configuration option to WebpackPluginConfig:

packageSourceMaps?: boolean;

Update the forgeConfig.packagerConfig.ignore function in WebpackPlugin.resolveForgeConfig to return true if the filename ends in .js.map unless the above configuration option is set to true.

[phuctm97]

Can someone review and merge this. This looks really good.

[zac-jacobson]

Thanks for the review @erickzhao, I have made a change to address your comments.

[codecov]

Codecov Report

Merging #2581 (8fa6320) into master (cdbf7a6) will increase coverage by 9.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2581      +/-   ##
==========================================
+ Coverage   66.27%   75.64%   +9.37%     
==========================================
  Files          91       77      -14     
  Lines        2775     2361     -414     
  Branches      679      439     -240     
==========================================
- Hits         1839     1786      -53     
+ Misses        808      423     -385     
- Partials      128      152      +24     

Impacted Files	Coverage Δ
packages/plugin/webpack/src/WebpackPlugin.ts	38.57% <100.00%> (+1.27%)	⬆️
packages/plugin/base/src/Plugin.ts	57.14% <0.00%> (-30.36%)	⬇️
packages/installer/dmg/src/util/hdiutil.ts	25.00% <0.00%> (-26.86%)	⬇️
packages/installer/exe/src/InstallerExe.ts	60.00% <0.00%> (-15.00%)	⬇️
packages/installer/linux/src/InstallerLinux.ts	41.66% <0.00%> (-8.34%)	⬇️
packages/api/core/src/util/rebuild.ts	94.73% <0.00%> (-5.27%)	⬇️
packages/api/core/src/api/init.ts	91.66% <0.00%> (-3.08%)	⬇️
packages/api/cli/src/util/terminate.ts	18.75% <0.00%> (-1.25%)	⬇️
packages/api/core/src/util/yarn-or-npm.ts	93.33% <0.00%> (-1.12%)	⬇️
packages/maker/flatpak/src/MakerFlatpak.ts	80.95% <0.00%> (-0.87%)	⬇️
... and 65 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbf7a6...8fa6320. Read the comment docs.

[erickzhao]

Sorry for a bit of nitpicking, but after giving this a bit more thought, I feel like making the flag more descriptive towards packaging might be useful, since there's no indication that this is for the package build only.

i.e.

- includeSourceMap
+ packageSourceMaps

[phuctm97]

Sorry for a bit of nitpicking, but after giving this a bit more thought, I feel like making the flag more descriptive towards packaging might be useful, since there's no indication that this is for the package build only.

i.e.

- includeSourceMap
+ packageSourceMaps

Eagerly waiting for this to be merged 😁

[zac-jacobson]

i.e.

- includeSourceMap
+ packageSourceMaps

Makes sense @erickzhao , updated.