Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace colors with chalk #2666

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jan 9, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #2665 by removing it altogether.

TODO

@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

Merging #2666 (c4ed80c) into master (0a71bc6) will increase coverage by 11.81%.
The diff coverage is 49.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2666       +/-   ##
===========================================
+ Coverage   52.30%   64.12%   +11.81%     
===========================================
  Files          74       77        +3     
  Lines        2537     2606       +69     
  Branches      573      583       +10     
===========================================
+ Hits         1327     1671      +344     
+ Misses       1052      752      -300     
- Partials      158      183       +25     
Impacted Files Coverage Δ
packages/api/core/src/api/index.ts 48.83% <ø> (+10.20%) ⬆️
packages/api/core/src/api/lint.ts 60.00% <ø> (+36.92%) ⬆️
packages/api/cli/src/util/terminate.ts 18.75% <9.09%> (-1.25%) ⬇️
packages/api/core/src/api/package.ts 62.96% <33.33%> (+45.37%) ⬆️
packages/utils/async-ora/src/ora.ts 60.60% <40.00%> (+30.30%) ⬆️
packages/api/core/src/api/make.ts 64.75% <40.90%> (+22.95%) ⬆️
packages/api/core/src/api/import.ts 51.58% <50.00%> (+37.18%) ⬆️
packages/api/core/src/api/start.ts 48.88% <50.00%> (+2.22%) ⬆️
packages/plugin/webpack/src/WebpackPlugin.ts 37.94% <50.00%> (+0.31%) ⬆️
packages/utils/async-ora/src/ora-handler.ts 76.92% <66.66%> (+7.69%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a71bc6...c4ed80c. Read the comment docs.

@malept malept force-pushed the malept/fix/replace-colors-with-chalk branch from 4ca8000 to c4ed80c Compare January 9, 2022 17:17
@malept malept marked this pull request as ready for review January 9, 2022 17:33
@malept malept merged commit e909ae8 into master Jan 9, 2022
@malept malept deleted the malept/fix/replace-colors-with-chalk branch January 9, 2022 17:44
@kyruzic
Copy link
Contributor

kyruzic commented Jan 9, 2022

Thanks for getting this done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors js 1.4.1 has been compromised. Immediate fix is needed.
2 participants