-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling maker in config #2754
Conversation
ef05dda
to
c66f82d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2754 +/- ##
==========================================
- Coverage 74.06% 73.94% -0.12%
==========================================
Files 77 77
Lines 2356 2357 +1
Branches 436 437 +1
==========================================
- Hits 1745 1743 -2
- Misses 462 464 +2
- Partials 149 150 +1
Continue to review full report at Codecov.
|
packages/api/core/test/fixture/app-with-maker-disable/package.json
Outdated
Show resolved
Hide resolved
🚲 🏚️ : I generally prefer having positive config options ( |
I just wanted to do the impl from the original issue, but we do have a |
I'd generally argue that those concepts are different enough that consistency in this case is a little weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - test failing is a CodeCov difference, which I'm not concerned about
Summarize your changes:
Closes #1632