-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update electron-packager to v16 #2927
chore: update electron-packager to v16 #2927
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2927 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 79 79
Lines 2412 2412
Branches 452 452
=======================================
Hits 1720 1720
Misses 563 563
Partials 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the PR, but as a general policy, I'm against merging PRs which come from non-maintainers that change yarn.lock. for details, see https://snyk.io/blog/why-npm-lockfiles-can-be-a-security-blindspot-for-injecting-malicious-modules/
That being said, I think we need to either re-enable Dependabot for major version bumps, or move to something like Renovate.
d17e6dc
to
c7d7c4e
Compare
Thanks for the feedback, I've removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikian I went ahead and added the yarn.lock 🙂 Thanks for the PR!
a5e8975
to
f4af4b2
Compare
Summarize your changes:
Update electron-packager to v16