Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update electron-packager to v16 #2927

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

erikian
Copy link
Member

@erikian erikian commented Aug 26, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Update electron-packager to v16

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #2927 (5264607) into master (5264607) will not change coverage.
The diff coverage is n/a.

❗ Current head 5264607 differs from pull request most recent head f4af4b2. Consider uploading reports for the commit f4af4b2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2927   +/-   ##
=======================================
  Coverage   71.31%   71.31%           
=======================================
  Files          79       79           
  Lines        2412     2412           
  Branches      452      452           
=======================================
  Hits         1720     1720           
  Misses        563      563           
  Partials      129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5264607...f4af4b2. Read the comment docs.

malept
malept previously requested changes Aug 26, 2022
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the PR, but as a general policy, I'm against merging PRs which come from non-maintainers that change yarn.lock. for details, see https://snyk.io/blog/why-npm-lockfiles-can-be-a-security-blindspot-for-injecting-malicious-modules/

That being said, I think we need to either re-enable Dependabot for major version bumps, or move to something like Renovate.

@erikian erikian force-pushed the chore/update-electron-packager branch from d17e6dc to c7d7c4e Compare August 26, 2022 17:11
@erikian
Copy link
Member Author

erikian commented Aug 26, 2022

Thanks for the feedback, I've removed yarn.lock from the PR. Maybe this information should be added to CONTRIBUTING.md?

@erikian erikian requested a review from malept August 26, 2022 18:46
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikian I went ahead and added the yarn.lock 🙂 Thanks for the PR!

@erikian erikian force-pushed the chore/update-electron-packager branch from a5e8975 to f4af4b2 Compare September 7, 2022 23:26
@VerteDinde VerteDinde dismissed malept’s stale review October 5, 2022 02:48

Relevant changes made

@VerteDinde VerteDinde merged commit 5b9a596 into electron:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants