Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): avoid generating Typescript utility types #2980

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

erickzhao
Copy link
Member

Adds '**/node_modules/typescript/**' to the settings for TypeDoc so we don't export internal TypeScript utility types like Record or Omit.

@erickzhao erickzhao requested a review from a team October 20, 2022 21:37
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #2980 (36f65ad) into main (a8b9dfc) will decrease coverage by 19.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2980       +/-   ##
===========================================
- Coverage   73.78%   54.23%   -19.55%     
===========================================
  Files          66       47       -19     
  Lines        2144     1451      -693     
  Branches      423      292      -131     
===========================================
- Hits         1582      787      -795     
- Misses        359      561      +202     
+ Partials      203      103      -100     
Impacted Files Coverage Δ
packages/api/core/src/util/upgrade-forge-config.ts 10.52% <0.00%> (-87.72%) ⬇️
packages/api/core/src/util/publish-state.ts 12.82% <0.00%> (-79.49%) ⬇️
packages/api/core/src/util/electron-executable.ts 24.00% <0.00%> (-76.00%) ⬇️
packages/maker/dmg/src/MakerDMG.ts 33.33% <0.00%> (-61.67%) ⬇️
packages/maker/deb/src/MakerDeb.ts 33.33% <0.00%> (-57.58%) ⬇️
packages/maker/rpm/src/MakerRpm.ts 33.33% <0.00%> (-57.58%) ⬇️
packages/maker/snap/src/MakerSnap.ts 41.66% <0.00%> (-51.67%) ⬇️
packages/maker/wix/src/util/author-name.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/maker/appx/src/util/author-name.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/api/core/src/api/publish.ts 18.42% <0.00%> (-50.00%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b9dfc...36f65ad. Read the comment docs.

@erickzhao erickzhao merged commit 4d80cb3 into main Oct 20, 2022
@erickzhao erickzhao deleted the docs/no-typescript-primitives branch October 20, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants