Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publisher-s3): Add sessionToken and change default fallback #2984

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

bboure
Copy link
Contributor

@bboure bboure commented Oct 23, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

  • add a sessionToken option
  • change the fallback to use the credential provider chain

Fixes #2983

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #2984 (9969f8b) into main (bb29cd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2984   +/-   ##
=======================================
  Coverage   73.78%   73.78%           
=======================================
  Files          66       66           
  Lines        2144     2144           
  Branches      423      423           
=======================================
  Hits         1582     1582           
  Misses        357      357           
  Partials      205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb29cd5...9969f8b. Read the comment docs.

Comment on lines +93 to +94
const accessKeyId = this.config.accessKeyId;
const secretAccessKey = this.config.secretAccessKey;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could we re-add the process.env fallbacks here, so that these are included if they're not in the config (CI could be a use case here)?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This GitHub Action does use environment variables! https://github.com/aws-actions/configure-aws-credentials

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VerteDinde if the credentials are not in the config and present in the process.env, the SDK will use them without needing to pass them explicitly.

THis is the recommended way. See doc

@MarshallOfSound MarshallOfSound merged commit 72b80a7 into electron:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 publisher should support session token
5 participants