Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename some constructor params for MakerBase and PublisherBase #2994

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 26, 2022

Just some renames so the generated docs / type hints are more readable / understandable. (I had no idea what providedPlatforms was so I figured it out and renamed the param).

This also deletes @scope-package-linux-x64-1.0.0.zip because why did that exist...

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2994 (e5db8af) into main (1472149) will increase coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2994      +/-   ##
==========================================
+ Coverage   73.80%   73.84%   +0.04%     
==========================================
  Files          67       67              
  Lines        2168     2168              
  Branches      436      436              
==========================================
+ Hits         1600     1601       +1     
+ Misses        361      360       -1     
  Partials      207      207              
Impacted Files Coverage Δ
packages/publisher/base/src/Publisher.ts 62.50% <50.00%> (ø)
packages/maker/base/src/Maker.ts 72.72% <80.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1472149...e5db8af. Read the comment docs.

@MarshallOfSound MarshallOfSound force-pushed the maker-publisher-constructor-names branch from a318431 to e5db8af Compare October 26, 2022 10:19
@MarshallOfSound MarshallOfSound requested a review from a team October 26, 2022 10:20
@MarshallOfSound MarshallOfSound merged commit b97c906 into main Oct 26, 2022
@MarshallOfSound MarshallOfSound deleted the maker-publisher-constructor-names branch October 26, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants