Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(maker-squirrel): ensure Squirrel.Windows name doesn't contain hyphens #3004

Merged
merged 4 commits into from
Oct 27, 2022
Merged

refactor(maker-squirrel): ensure Squirrel.Windows name doesn't contain hyphens #3004

merged 4 commits into from
Oct 27, 2022

Conversation

erickzhao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Makes some code a lot simpler ❤️

@erickzhao erickzhao requested a review from a team October 26, 2022 23:19
erickzhao and others added 2 commits October 26, 2022 18:04
@erickzhao
???
068e1f2
@erickzhao @MarshallOfSound
Update packages/maker/squirrel/src/MakerSquirrel.ts
ce72c0d 
Co-authored-by: Samuel Attard <sam@electronjs.org>
@erickzhao erickzhao merged commit 35a26ea into main Oct 27, 2022
@erickzhao erickzhao deleted the refactor/delete-some-old-code branch October 27, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erickzhao @VerteDinde @MarshallOfSound