Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): keep devDependencies, dependencies, optionalDependencies and peerDependencies in the distributed package.json #3007

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

erikian
Copy link
Member

@erikian erikian commented Oct 27, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

As mentioned in #2818 (comment), the Webpack plugin sets the devDependencies, dependencies, optionalDependencies and peerDependencies objects to {} in the distributed package.json. If any other plugin runs after the Webpack plugin and tries to read one of these objects, it will get an empty object instead of the actual dependencies, which seems like an unexpected side-effect.

Fixes #2818.

…lDependencies` and `peerDependencies` in the distributed package.json
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikian Thanks for the PR (and for your prior PRs, we get excited when we see a submission from you! 😄)

@VerteDinde VerteDinde merged commit 0f75ce0 into electron:main Oct 27, 2022
@erikian
Copy link
Member Author

erikian commented Oct 27, 2022

@VerteDinde thanks, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugin-electronegativity error: "warn: Couldn't detect Electron version, assuming v0.1.0"
2 participants