Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use listr2 instead of async-ora #3022

Merged
merged 11 commits into from
Oct 31, 2022
Merged

refactor: use listr2 instead of async-ora #3022

merged 11 commits into from
Oct 31, 2022

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 30, 2022

This swap does a few cool things:

  • We can now have multiple spinners / progress indicators at the same time
  • We can associate output with a running task (thing piping a spawned process)
  • Tasks are now semantically ordered and we can visually indicate "subtasks"
  • It looks cooler ✨ 😎

This refactor can be done bit-by-bit, this PR tackles the top level checkSystem command and the init + start subcommands. Other commands can be ported ad-hoc with the exception of packager which shouldn't be ported until #3006 lands or is in a state to be cherry-picked.

api/core already depended on listr2 as well so this doesn't add anything to our dependency tree.

Screenshots

Init with template-webpack

image

Start with native module failure

image

Start with plugin-webpack

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants