Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pass this.config when calling internal hooks #3126

Merged

Conversation

albertxing
Copy link
Contributor

@albertxing albertxing commented Dec 31, 2022

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Some internal hooks are decorated with the __hookName field to indicate that the first parameter should be the task. However, when invoking these callbacks the config param was left out. This resulted in a signature mismatch, which caused issues like #3114 where the arch param was not being passed along correctly to rebuild.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@erickzhao erickzhao changed the title fix: pass this.config when calling internal hooks fix(core): pass this.config when calling internal hooks Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants