Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create a test:slow script to avoid re-running fast tests in the slow-tests job #3150

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

erikian
Copy link
Member

@erikian erikian commented Feb 1, 2023

slow-tests job

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Basically the title. This PR slashes a minute or so (~10%-ish) from the time it takes to run the slow tests by not re-running the fast tests, which are already covered by a separate job.

@erikian erikian requested a review from a team as a code owner February 1, 2023 02:12
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit thanks!

@erickzhao erickzhao merged commit 663a0f8 into electron:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants