Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Electron Packager official platform/arch list #320

Merged
merged 3 commits into from Sep 16, 2017

Conversation

malept
Copy link
Member

@malept malept commented Sep 12, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This replaces the broken test on Windows with a set of unit tests that just tests parsing an arch value. Retrieving archs when arch is all has been delegated to Electron Packager.

This is a WIP because I want to make sure the testsuite passes in AppVeyor.

TODO

  • Add API to Electron Packager to get arches for a given platform and version (needed for the arm64 + Linux + Electron >= 1.8.0 case) - Add target arch API packager#727
  • Utilize the new API

@malept malept mentioned this pull request Sep 13, 2017
5 tasks
@malept malept force-pushed the use-electron-packager-arch-list branch from 18e41d2 to 17964f0 Compare September 16, 2017 02:06
@malept malept changed the title [WIP] Use the Electron Packager official platform/arch list Use the Electron Packager official platform/arch list Sep 16, 2017
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're all clear that electron-packager/targets is now public API I'm 👍

@malept
Copy link
Member Author

malept commented Sep 16, 2017

I should probably document it more but anything exported in Packager is fair game as far as "public API" is concerned. If it's exported, more often than not I have unit tests for it.

I just need to remember to major version bump more often.

@malept malept merged commit 45afdfb into master Sep 16, 2017
@malept malept deleted the use-electron-packager-arch-list branch September 16, 2017 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants