refactor(maker): replace zip-folder with cross-zip

[malept]

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• The changes are appropriately documented (if applicable).
• The changes have sufficient test coverage (if applicable).
• The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Replacing zip-folder to get rid of a dependency with a security vulnerability.

ISSUES CLOSED: #322

[malept]

We should probably make sure that Mac zip files store symlinks correctly.

[MarshallOfSound]

@malept It looks like cross-zip uses the same zip args as us but I would like some manual validation that this doesn't break out zipping 👍

[hacdias]

Hello, are there any developments on this?

[malept]

@hacdias it's blocked on people testing it. See instructions in #331 (comment) for testing.

[malept]

To make it a little easier for people to test, I've generated some ZIP files for my demo app:

https://github.com/malept/electron-forge-demo123/releases/tag/v1.4.0

In particular, I would like feedback on the darwin (macOS) zip, to make sure that one still works. I've tested the Linux one.

[MarshallOfSound]

This should target master methinks, would feel more comfortable now that this maker is extracted into it's own package if this PR just came with simple tests that zips generated with this package can be unzipped using platform specific commands. I.e. Running ps on Windows and unzip on Darwin/*nix

[malept]

I'll need some help with the Windows tests then 😄

[MarshallOfSound]

I'll do windows if you've got dem unix ones 👍

[malept]

I'll do windows if you've got dem unix ones 👍

Done!

[MarshallOfSound]

@malept Can we put the zip / unzip test in the @electron-forge/maker-zip module folder. Just so that tests are scoped right 🤔 core shouldn't fail if zip is broken IMO (I'll be working on relocating some tests over the coming weeks)

[malept]

I agree in principle, but the problem is that we'll need to figure out how to persist a packaged app between module tests, otherwise the test run time will skyrocket to unacceptable levels.