-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(maker): replace zip-folder with cross-zip #325
Conversation
We should probably make sure that Mac zip files store symlinks correctly. |
@malept It looks like |
1739b22
to
a9b3986
Compare
0dde7de
to
bbe1362
Compare
4d02b57
to
e5a40c4
Compare
Hello, are there any developments on this? |
@hacdias it's blocked on people testing it. See instructions in #331 (comment) for testing. |
2a253a3
to
4005dcc
Compare
To make it a little easier for people to test, I've generated some ZIP files for my demo app: https://github.com/malept/electron-forge-demo123/releases/tag/v1.4.0 In particular, I would like feedback on the darwin (macOS) zip, to make sure that one still works. I've tested the Linux one. |
This should target master methinks, would feel more comfortable now that this maker is extracted into it's own package if this PR just came with simple tests that zips generated with this package can be unzipped using platform specific commands. I.e. Running |
I'll need some help with the Windows tests then 😄 |
I'll do windows if you've got dem unix ones 👍 |
Done! |
@malept Can we put the |
I agree in principle, but the problem is that we'll need to figure out how to persist a packaged app between module tests, otherwise the test run time will skyrocket to unacceptable levels. |
ISSUES CLOSED: #322
Summarize your changes:
Replacing zip-folder to get rid of a dependency with a security vulnerability.
ISSUES CLOSED: #322