fix(plugin-webpack): preload race condition #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikian
previously requested changes
Sep 15, 2023
|
Whoops, didn't notice it was a draft 😅 |
georgexu99
force-pushed
the
webpack-race-condition
branch
from
8f7aa47
to
3fc0dd2
Compare
erickzhao
changed the title
VerteDinde
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3343
Due to webpack preload refactoring, a bug mainly affecting windows resulted in users temporarily seeing an error as the window attempted to display preload contents before webpack was done compiling the preload. This PR introduces logic to wait for preload compilation to finish first.