feat: add tracing support for forge API #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
force-pushed
the
tracing
branch
from
4ddbc99
to
df9d0f1
Compare
|
Thought I commented on this in the past but guess I never sent it. Overall LGTM and seems like a dope thing to support. Would there be any benefit to making |
erickzhao
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this diff with whitespace disabled 🙇
This is kinda ready but also kinda a WIP, this adds all the tracing but no flags for actually getting the trace output. Just want folks thoughts on the approach
The idea here is the sub ecosystem modules + makers + publishers + plugins will also call into
@electron-forge/tracer