New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(maker-dmg): make 'name' optional in DMGContents interface #3390

Merged

MarshallOfSound merged 1 commit into electron:main from BitYoungjae:align-dmg-contents-with-appdmg

Nov 2, 2023

Contributor

BitYoungjae commented Oct 25, 2023

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
The changes are appropriately documented (if applicable).
The changes have sufficient test coverage (if applicable).
The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR updates the DMGContents interface to align with the appdmg dependency, where the name property is optional.


          fix(maker-dmg): make 'name' optional in DMGContents interface

b2f84c2

Aligns DMGContents with appdmg's definition where 'name' is optional.

BitYoungjae requested a review from a team as a code owner

October 25, 2023 08:34

MarshallOfSound approved these changes

View reviewed changes

MarshallOfSound merged commit 6990f33 into electron:main

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment