Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): replace intermittently failing to rebuild newrelic module with cld #36

Closed
wants to merge 2 commits into from

Conversation

malept
Copy link
Member

@malept malept commented Dec 18, 2016

Have you read the section in CONTRIBUTING.md about pull requests?

Yes

Are your changes appropriately documented?

N/A

Do your changes have sufficient test coverage?

Yes

Does the testsuite pass successfully on your local machine?

Yes

Summarize your changes:

  • replace the newrelic module with one that hopefully rebuilds more consistently on Windows (and also has a better license)
  • DRY up the rebuild tests

@malept
Copy link
Member Author

malept commented Dec 18, 2016

Hmmm. I think it's less to do with the module itself and perhaps more to do with Windows + Node async? (For reference, it passed the first AppVeyor PR build, then I re-ran it to be more confident that it wasn't a fluke.)

gyp ERR! build error 
gyp ERR! stack Error: EBUSY: resource busy or locked, open 'C:\Users\appveyor\.electron-gyp\.node-gyp\iojs-1.4.12\Release\iojs.lib'
gyp ERR! stack     at Error (native)

(iojs?!)

@MarshallOfSound
Copy link
Member

@malept Maybe on windows due to resource locking we have to rebuild sequentially?

@malept
Copy link
Member Author

malept commented Dec 19, 2016

@MarshallOfSound

Maybe on windows due to resource locking we have to rebuild sequentially?

That's pretty likely. electron-rebuild doesn't run into this?

@MarshallOfSound
Copy link
Member

@malept This will be handled by the default sequential / parallel behavior of my electron-rebuild port / branch.

https://github.com/electron/electron-rebuild/tree/new-rebuild

@malept malept mentioned this pull request Jan 2, 2017
@malept
Copy link
Member Author

malept commented Jan 7, 2017

Obsoleted by #70.

@malept malept closed this Jan 7, 2017
@malept malept deleted the change-scoped-native-module-test branch January 7, 2017 10:43
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
feat: A "Welcome to Electron Fiddle" Tour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants