feat(core): allow mutating packageJSON on load #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to override fields like "version" at build time this provides the ability to intercept forge loading your package.json file and modify the JS files we read
malept
approved these changes
May 27, 2018
|
|
||
| // TODO: Move this check to inside the forge config resolver and use | ||
| // mutatedPackageJson reader |
There was a problem hiding this comment.
Is this for a different PR then?
b-zurg
reviewed
May 6, 2020
| d(`hook triggered: ${hookName}`); | ||
| if (typeof hooks[hookName] === 'function') { | ||
| d('calling mutating hook:', hookName, 'with item:', item); | ||
| const result = await hooks[hookName](forgeConfig, item); |
There was a problem hiding this comment.
Why pass the forgeConfig into the hook first? This was a bit cryptic to find from the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
In order to override fields like "version" at build time. This provides the ability
to intercept forge loading your package.json file and modify the JS object we read in
Docs: https://v6.electronforge.io/configuration#readpackagejson