Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(maker-deb): return the correct outPath with a prerelease version #584

Merged
merged 2 commits into from
Oct 9, 2018
Merged

fix(maker-deb): return the correct outPath with a prerelease version #584

merged 2 commits into from
Oct 9, 2018

Conversation

malept
Copy link
Member

@malept malept commented Oct 3, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

ISSUES CLOSED: #583

MarshallOfSound
MarshallOfSound reviewed Oct 3, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
@malept malept force-pushed the fix-publishing-prerelease-debs branch from e362122 to e837850 Compare October 9, 2018 01:03
@malept malept force-pushed the fix-publishing-prerelease-debs branch from e837850 to 3a4b44a Compare October 9, 2018 01:08
@malept malept changed the title [WIP] fix(maker-deb): return the correct outPath with a prerelease version fix(maker-deb): return the correct outPath with a prerelease version Oct 9, 2018
@malept
Copy link
Member Author

malept commented Oct 9, 2018

@MarshallOfSound this is ready for a real review now 😄

@MarshallOfSound MarshallOfSound merged commit a4fbc0a into master Oct 9, 2018
@MarshallOfSound MarshallOfSound deleted the fix-publishing-prerelease-debs branch October 9, 2018 02:09
@malept malept mentioned this pull request Oct 9, 2018
Merged
5 tasks
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@github-actions @electron-bot @erickzhao
build: update Electron releases JSON (#584)
b302855 
* build: update Electron releases JSON

* build: update Electron releases JSON

* build: update Electron releases JSON

* build: update Electron releases JSON

* build: update Electron releases JSON

* Trigger Build

Co-authored-by: Electron Bot <electron-bot@users.noreply.github.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@malept @MarshallOfSound