Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Node 8 support #875

Merged
merged 5 commits into from May 23, 2019
Merged

feat: Node 8 support #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a1a495
chore: raise Node dependency to >= 8
malept May 10, 2019
8d5e937
chore: test CI against Node 8
malept May 17, 2019
38d9f64
chore: upgrade packages that require Node 8
malept May 10, 2019
12a05e2
chore: opn is now open
malept May 17, 2019
a3e2530
chore: remove CI branch config
malept May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .appveyor.yml
View file
Open in desktop
@@ -1,7 +1,7 @@
platform:
- x64
environment:
nodejs_version: "6"
nodejs_version: "8"
matrix:
- node_installer: yarn
cache:
Expand All @@ -10,7 +10,6 @@ cache:
branches:
only:
- master
- v6

install:
- ps: Install-Product node $env:nodejs_version $env:platform
Expand Down
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
@@ -1,5 +1,5 @@
language: node_js
node_js: '6'
node_js: '8'
dist: xenial
osx_image: xcode8.3
cache: npm
Expand Down
2 changes: 1 addition & 1 deletion ci/script.sh
View file
Open in desktop
@@ -1,7 +1,7 @@
#!/bin/bash -e

if [[ "$TRAVIS_OS_NAME" = "linux" ]]; then
sudo docker run --privileged --interactive --tty --volume $(pwd):/code malept/electron-forge-container:latest /code/ci/docker.sh $NODE_INSTALLER
sudo docker run --privileged --interactive --tty --volume $(pwd):/code malept/electron-forge-container:node-8 /code/ci/docker.sh $NODE_INSTALLER
else
bolt
yarn build
Expand Down
12 changes: 5 additions & 7 deletions package.json
View file
Open in desktop
Expand Up @@ -64,22 +64,22 @@
"inquirer": "^6.3.1",
"lodash.merge": "^4.6.0",
"lodash.template": "^4.4.0",
"log-symbols": "^2.0.0",
"log-symbols": "^3.0.0",
"mime-types": "^2.1.24",
"node-fetch": "^2.6.0",
"node-gyp": "^4.0.0",
"nugget": "^2.0.1",
"opn": "^5.0.0",
"open": "^6.0.0",
"ora": "^3.0.0",
"parse-author": "^2.0.0",
"pify": "^4.0.0",
"pretty-ms": "^4.0.0",
"pretty-ms": "^5.0.0",
"resolve-package": "^1.0.1",
"s3": "^4.4.0",
"semver": "^6.1.0",
"source-map-support": "^0.5.12",
"sudo-prompt": "^8.0.0",
"username": "^4.0.0",
"username": "^5.0.0",
"webpack": "^4.32.2",
"webpack-dev-middleware": "^3.7.0",
"webpack-hot-middleware": "^2.25.0",
Expand Down Expand Up @@ -112,13 +112,11 @@
"@types/listr": "^0.14.0",
"@types/lodash.merge": "^4.6.4",
"@types/lodash.template": "^4.4.4",
"@types/log-symbols": "^2.0.0",
"@types/mime-types": "^2.1.0",
"@types/minimist": "^1.2.0",
"@types/mocha": "^5.1.0",
"@types/node": "^12.0.2",
"@types/node-fetch": "^2.3.4",
"@types/opn": "^5.1.0",
"@types/pify": "^3.0.1",
"@types/pretty-ms": "^4.0.0",
"@types/proxyquire": "^1.3.28",
Expand All @@ -131,7 +129,7 @@
"@types/webpack-merge": "^4.1.5",
"@typescript-eslint/eslint-plugin": "^1.9.0",
"@typescript-eslint/parser": "^1.9.0",
"asar": "^1.0.0",
"asar": "^2.0.1",
"babel-plugin-source-map-support": "^2.0.1",
"chai": "4.2.0",
"chai-as-promised": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/api/cli/package.json
View file
Open in desktop
Expand Up @@ -26,6 +26,6 @@
"semver": "^6.1.0"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
}
}
10 changes: 5 additions & 5 deletions packages/api/core/package.json
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@
"@electron-forge/maker-squirrel": "6.0.0-beta.34",
"@electron-forge/maker-wix": "6.0.0-beta.34",
"@electron-forge/maker-zip": "6.0.0-beta.34",
"asar": "^1.0.0",
"asar": "^2.0.1",
"chai": "4.2.0",
"chai-as-promised": "^7.0.0",
"fetch-mock": "^7.3.3",
Expand Down Expand Up @@ -47,18 +47,18 @@
"glob": "^7.1.4",
"lodash.merge": "^4.6.0",
"lodash.template": "^4.4.0",
"log-symbols": "^2.0.0",
"log-symbols": "^3.0.0",
"node-fetch": "^2.6.0",
"nugget": "^2.0.1",
"pify": "^4.0.0",
"resolve-package": "^1.0.1",
"semver": "^6.1.0",
"source-map-support": "^0.5.12",
"sudo-prompt": "^8.0.0",
"username": "^4.0.0",
"username": "^5.0.0",
"yarn-or-npm": "^2.0.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
}
}
}
2 changes: 1 addition & 1 deletion packages/installer/base/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/darwin/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/deb/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-linux": "6.0.0-beta.34"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/dmg/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-darwin": "6.0.0-beta.34",
Expand Down
6 changes: 3 additions & 3 deletions packages/installer/exe/package.json
View file
Open in desktop
Expand Up @@ -11,10 +11,10 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-base": "6.0.0-beta.34",
"opn": "^5.0.0"
"open": "^6.0.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/installer/exe/src/InstallerExe.ts
View file
Open in desktop
@@ -1,13 +1,13 @@
import InstallerBase, { InstallerOptions } from '@electron-forge/installer-base';

import opn from 'opn';
import open from 'open';

export default class InstallerExe extends InstallerBase {
name = 'exe';

async install({
filePath,
}: InstallerOptions) {
await opn(filePath, { wait: false });
await open(filePath, { wait: false });
}
}
2 changes: 1 addition & 1 deletion packages/installer/linux/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/rpm/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-linux": "6.0.0-beta.34"
Expand Down
2 changes: 1 addition & 1 deletion packages/installer/zip/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/installer-darwin": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/appx/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/base/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/shared-types": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/deb/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/dmg/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/flatpak/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/pkg/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/rpm/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/snap/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/squirrel/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/wix/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/maker/zip/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/maker-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/auto-unpack-natives/package.json
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
"main": "dist/AutoUnpackNativesPlugin.js",
"typings": "dist/AutoUnpackNativesPlugin.d.ts",
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/plugin-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/base/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/shared-types": "6.0.0-beta.34"
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/compile/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/local-electron/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/plugin-base": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/webpack/package.json
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/base/package.json
View file
Open in desktop
Expand Up @@ -13,6 +13,6 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
}
}
2 changes: 1 addition & 1 deletion packages/publisher/bitbucket/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/electron-release-server/package.json
View file
Open in desktop
Expand Up @@ -12,7 +12,7 @@
"mocha": "^6.1.4"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down
2 changes: 1 addition & 1 deletion packages/publisher/github/package.json
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@
"sinon": "^7.3.2"
},
"engines": {
"node": ">= 6.0"
"node": ">= 8.0"
},
"dependencies": {
"@electron-forge/async-ora": "6.0.0-beta.34",
Expand Down