Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

about mirrorOption version(x.x.x -> vx.x.x) #123

Closed
siaikin opened this issue Nov 2, 2019 · 3 comments · Fixed by #143
Closed

about mirrorOption version(x.x.x -> vx.x.x) #123

siaikin opened this issue Nov 2, 2019 · 3 comments · Fixed by #143
Labels
released

Comments

@siaikin
Copy link

siaikin commented Nov 2, 2019

commit code

i use this mirror 'https://npm.taobao.org/mirrors/electron/' in china.

in 7.0.0 '@electron/get' request wrong url:
'https://npm.taobao.org/mirrors/electron/v7.0.0/electron-v7.0.0-darwin-x64.zip'

but in 6.1.2 request this url:
'https://npm.taobao.org/mirrors/electron/6.1.2/electron-v6.1.2-darwin-x64.zip'

i seems in this code you sue v${version}. this should be the cause.

ps thanks @nickfan
@siaikin siaikin mentioned this issue Nov 7, 2019
Closed
@MarshallOfSound MarshallOfSound mentioned this issue Nov 29, 2019
Closed
@wells1013
Copy link

+1

@malept malept mentioned this issue Feb 11, 2020
Merged
@chanble chanble mentioned this issue Feb 22, 2020
Closed
@chanble
Copy link

chanble commented Feb 22, 2020

taobao mirror is update cnpm/cnpmjs.org#1551 (comment)

@electron-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
4 participants
@chanble @wells1013 @electron-bot @siaikin