Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: drop Node.js v14 #18

Closed
wants to merge 1 commit into from
Closed

ci: drop Node.js v14 #18

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Unblocks #15.

CircleCI has switched executors from MacOS / Medium Gen2 to MacOS / M1 Medium - Node.js v14 does not release an arm64 version and therefore does not work anymore.

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been working through these with @georgexu99, I've been trying to avoid dropping 14 unless we have to, and if we do, excluding just macOS so we still have 2/3 platform CI coverage.

In order of preference this is what I've been trying to do:

  • Pin to Node 14.16 - it's 14.17.0 and above where nvm tries to download binaries which don't exist (seems to be intentional behavior) - example here (requires installing Rosetta as well)
  • If that doesn't work (some repos require 14.17+ due to certain packages), then exclude macOS and v14 from the matrix - example here

@codebytere
Copy link
Member Author

given its long past EOL - why? Could we not at this point try adding 22?

@dsanders11
Copy link
Member

given its long past EOL - why?

The package supports v14, so we should test it in CI to prevent accidentally introducing breaking changes. At the moment Ecosystem WG policy is to minimize the number of breaking changes for any given package, so we've been avoiding dropping support for old Node.js versions unless we have to, or we're doing other breaking changes.

Could we not at this point try adding 22?

We could, but I think that's a separate question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants