docs: protocol api: simplification #368
Conversation
|
I like this general proposal but I think we can go further! I think we should just have one method, protocol.handle("app", async (request, next) => {
const response = await getResponseFor(request)
return response ?? next()
})Here protocol.handle("http", async (request, next) => {
if (request.path === '/')
// I'm unsure if this should be something like "new StringResponse", or whether
// a plain object is better
return {content: '<body>hello world', mime: 'text/html'}
else if (request.path === '/some/image.png')
return {file: '/path/to/my/image.png'}
else if (request.path === '/some/video.mp4')
return {content: generateVideoStream(), mime: 'video/mp4'}
else if (request.path === '/sneakily-cross-origin')
return {url: 'https://foo.bar/baz'}
else return next()
}) |
|
@nornagon has this design landed? |
|
@samuelmaddock, |
Simplification of the
protocolmodule APIs.Rendered markdown.