Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added abi version for electron 6 #67

Merged
merged 5 commits into from
Jun 19, 2019

Conversation

patrickrobbins
Copy link
Contributor

No description provided.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@dsanders11
Copy link
Member

@MarshallOfSound, @malept, can this or #65 be merged? 6.0.0 is on beta 9 now, and it's a pain to use the beta without this change. Not much point in having a futureTargets if it doesn't get used for something like the betas.

@malept
Copy link
Member

malept commented Jun 19, 2019

Sorry, I don't have commit rights to this repository.

@issacgerges
Copy link

Can raise a separate issue on electron-rebuild but it also may be worthwhile to have an optional --abi argument there that could be used to unblock folks in cases like this. Happy to do the work if it's something you want @MarshallOfSound

@MarshallOfSound
Copy link
Member

@issacgerges Maybe something like --force-abi=78 or similar, the ABI number is only used to de-dupe / determine when to rebuild 👍

@MarshallOfSound MarshallOfSound merged commit 165f884 into electron:master Jun 19, 2019
@lgeiger
Copy link
Contributor

lgeiger commented Jun 19, 2019

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dsanders11
Copy link
Member

Thanks @MarshallOfSound and @lgeiger for pushing it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants