-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prebuild minidump #42
Conversation
0dd75f1
to
f16a255
Compare
@nornagon Could you review this? |
Hey there, while publishing this I noticed that the Linux binaries are quite large, around 15 MB. I think this is because they are unstripped. Running Can we find a way to strip the linux binaries to reduce the download size? The breakpad source is itself already quite large. |
We can do it for all the binaries. Here is the code: |
This makes it possible to include the binaries in the npm package.
Description
The build script makes a
bin
folder that includes the binaries. These binaries are used by the main file.I assumed that the release process is done after manually by downloading the artifacts from the last GitHub action run. I can add an automatic release action if you prefer this to be done by the semantic-release bot.
Issues
Fixes #41
Verification
A successful CI run:
https://github.com/aminya/node-minidump/actions/runs/528963738
The artifacts:
https://github.com/aminya/node-minidump/suites/1945608672/artifacts/38471951