refactor: allow embedder overriding of internal FS calls

lib/internal/bootstrap/node.js

@@ -64,6 +64,10 @@ if (ownsProcessState) {
   );
 }
 
+// NOTE: Electron deletes this references before user code runs so that
+// internalBinding is not leaked to user code
+process.internalBinding = internalBinding;
+
 // process.config is serialized config.gypi
 process.config = JSON.parse(internalBinding('native_module').config);
 

lib/internal/modules/cjs/loader.js

@@ -29,10 +29,7 @@ const assert = require('internal/assert');
 const fs = require('fs');
 const internalFS = require('internal/fs/utils');
 const path = require('path');
-const {
-  internalModuleReadJSON,
-  internalModuleStat
-} = internalBinding('fs');
+const internalFsBinding = internalBinding('fs');
 const { safeGetenv } = internalBinding('credentials');
 const {
   makeRequireFunction,
@@ -87,13 +84,11 @@ const isWindows = process.platform === 'win32';
 let requireDepth = 0;
 let statCache = new Map();
 function stat(filename) {
-  // FIXME(codebytere): determine why this needs to be done and remove
-  const internalModuleStat = process.binding('fs').internalModuleStat;
   filename = path.toNamespacedPath(filename);
   if (statCache === null) statCache = new Map();
   let result = statCache.get(filename);
   if (result !== undefined) return result;
-  result = internalModuleStat(filename);
+  result = internalFsBinding.internalModuleStat(filename);
   statCache.set(filename, result);
   return result;
 }
@@ -206,7 +201,7 @@ function readPackage(requestPath) {
     return entry;
 
   const jsonPath = path.resolve(requestPath, 'package.json');
-  const json = internalModuleReadJSON(path.toNamespacedPath(jsonPath));
+  const json = internalFsBinding.internalModuleReadJSON(path.toNamespacedPath(jsonPath));
 
   if (json === undefined) {
     return false;