Command failed when signing app

[tatgean]

....
electron-packager . $APP --platform=darwin --arch=x64 \
  --out dist \
  --ignore=build \
  --ignore=config/development.json \
  --overwrite \
  --prune \
  --icon=appicon.icns \
  --app-bundle-id="com.example.myapp" \
  --build-version=$BUILD --app-version=$VERSION \

electron-osx-sign "dist/myapp/myapp.app" \
  --identity="$DEVELOPER_KEY"

keep showing the following error:

Command failed: codesign --sign Developer ID Application: XXXXXXXXXX --force dist/myapp/myapp.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework

where Developer ID Application: XXXXXXXXXX is a valid cert.

My electron-osx-sign version is 0.4.4 and electron-packager is 8.0.0

Anyone can help?
Thanks.

[sethlu]

Hi @tatgean, would you mind posting your debug log here with export DEBUG=electron-osx-sign* before running electron-osx-sign "dist/myapp/myapp.app" --identity="$DEVELOPER_KEY"? I'm not very sure what causes the issue.

Also, if there aren't multiple signing certs (beginning with Developer ID Application) in your default keychain I would recommend running electron-osx-sign "dist/myapp/myapp.app" and let electron-osx-sign find the matching identity.

---

security find-identity -v -p codesigning should display a list of valid certs for code signing. And the certificate Developer ID Application should be listed there.

[tatgean]

Please refer to this post.

It seems there are some problems with codesign on macOS 10.12. To address the issue,

1. use the cert id instead of the cert name to sign the app.
2. use --timestamp=none.

I've sent 2 pull requests, #133 and #134,
For me, using cert id( #134 ) just works for me,
but It seems there are some users reported using --timestamp=none works for them so I've sent another pull request( #133 ) to add the --timestamp-none option.

[sethlu]

@tatgean thanks for suggesting the changes! I really like the solution #134 by calling codesign with the certificate id (40 hex digits), and potentially use that as a default if it works across the recent macOS versions? 👍
Ref: sethlu@d6be2dc

Regarding #133, I think an option for --timestamp may be exposed to the user so the timestamp server may be manually set in the future?

[sethlu]

Hi @tatgean, I've just merged your recent PRs and a new version should be released shortly.
Thanks for posting the fixes for the cert issue! 👍