Helper IDs

[jasonhinkle]

This is fantastic. I've used this app to sign my application and I've nearly gotten through every issue to submit to the MAS with just two remaining.

The Frameworks have three Helper apps Helper, Helper.EH and Helper.NP. Using your pull request to electron-packager I've created the package file and it correctly changes the bundle id for the helper, however the EH and NP bundle ids still have the original github.electron id. I went in and manually changed those IDs to com.mydomain.myapp.helper.EH and com.mydomain.myapp.helper.NP. The application loader is now down to just two errors. Basically it's the same error for each of those files:

"Bad CFBundleExecutable. Cannot find executable file that matches the value of CFBundleExecutable in the nested bundle Electron Helper EH [com.mydomain.myapp.pkg/Payload/MyApp.app/Contents/Frameworks/MyApp Helper EH.app] property list file"

I'm not sure if I've named these improperly in the plist files? Or do I need to add those bundle IDS on iTunes Connect? I'm kinda stumped at this point.

Thanks for any help on this!

[jasonhinkle]

With a little more research I figured out how all of the values need to be set in the plist files for the EH and NP helper apps. I posted more info here electron/packager#261 It seems like it's probably more of an issue that should be solved in electron-packager rather than the signing app?

[sethlu]

Hi @jasonhinkle, I'll say this may depend more on the electron-packager on which I'm running a pull request here electron/packager#223. I could integrate the automation of CFBundleExecutable and CFBundleIdentifier so it may be easier.

[jasonhinkle]

I would agree, I think those plist files are really part of the "package" and not really the signing. If you added them to your pull request then it would be even that much better. I currently just have a shell script that is doing the renaming:

APP="My App"
APP_BUNDLE_ID="com.mydomain.myapp"

sed -i "" "s/com\.github\.electron\.helper\.EH/$APP_BUNDLE_ID\.helper\.EH/g" "$FRAMEWORKS_PATH/$APP Helper EH.app/Contents/Info.plist"
sed -i "" "s/Electron Helper/$APP Helper/g" "$FRAMEWORKS_PATH/$APP Helper EH.app/Contents/Info.plist"
sed -i "" "s/com\.github\.electron\.helper\.NP/$APP_BUNDLE_ID\.helper\.NP/g" "$FRAMEWORKS_PATH/$APP Helper NP.app/Contents/Info.plist"
sed -i "" "s/Electron Helper/$APP Helper/g" "$FRAMEWORKS_PATH/$APP Helper NP.app/Contents/Info.plist"

[sethlu]

Hi @jasonhinkle, I've already added in the lines to automatically rename the helper EH/NP apps along the other files. One thing to note is that after renaming any files, or editing any plists, do re-codesign the application package to avoid unsigned parts.

[jasonhinkle]

Awesome! One thing though is that the BundleId seems to be "com.mydomain.myapp.helper" for all three of the helpers. I'm not sure if this matters or not? For my submission the EH one the id is "com.mydomain.myapp.helper.EH" and the NP one is "com.mydomain.myapp.helper.NP"

My app is pending review right now so I can't submit another binary to test it. But, I do know that it worked with those IDs.

(Sorry this is here instead of your electron-packager build - we can move discussion there if you prefer)

[sethlu]

@jasonhinkle I think for each of the helper apps Helper, Helper EH and Helper NP should have a different CFBundleIdentifier like what you mentioned.
I still have an app with review pending. After getting something from iTunes Connect may I know where to fix with this codesign wrapper I guess.

[jasonhinkle]

That sounds great. I'll keep testing away too. Thanks for building these two tools, without your pull request and this signing app I don't think I would have been able to get my app built correctly. I'm sending more feature requests your way - if you like any of these ideas but want some help, let me know and I can probably find some time to code and submit pull requests.

[sethlu]

@jasonhinkle I could plan to work on #5 as it is a quick fix for productbuild. As for #6, personally never having packed any binaries into Electron yet, I think running a deep search in the directory and sign every binary file may work easier than specifying individual binaries as parameters?
We could continue having the discussion in the feature requests so to lay out everything neatly.

[onmyway133]

@jasonhinkle @sethlu Hi, I'm having this issue too onmyway133/notes#541

How did you solve this?