Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle ID for Helper EH and Helper NP #261

Closed
jasonhinkle opened this issue Feb 9, 2016 · 5 comments
Closed

Bundle ID for Helper EH and Helper NP #261

jasonhinkle opened this issue Feb 9, 2016 · 5 comments
Labels
bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS

Comments

@jasonhinkle
Copy link
Contributor

The helper-bundle-id argument correctly sets the bundle id for the Helper app in it's plist file. However the Helper EH and Helper NP still have the original electron bundle ID.
@jasonhinkle
Copy link
Contributor Author

Going in a little deeper, the Bundle Name and Executable properties need to be updated as well in order to be accepted to the Mac App Store. Here's an example of the NP plist that works and was accepted to the app store.

screen shot 2016-02-09 at 9 13 05 pm

@malept
Copy link
Member

malept commented Feb 10, 2016

Would #253 solve this problem?

@malept malept added bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS labels Feb 10, 2016
@jasonhinkle jasonhinkle mentioned this issue Feb 10, 2016
Closed
@sethlu sethlu mentioned this issue Feb 10, 2016
Merged
@jasonhinkle
Copy link
Contributor Author

The extra info would probably work but really the packager already has the information it needs and is already renaming the helper files. So it seems like the default would be to put those values into the plist files. As is, the plist files are technically invalid, though it only comes into play when you try to submit to the app store.

@malept
Copy link
Member

malept commented Feb 10, 2016

Evidently the author of #223 noticed this bug and is going to fix it.

sethlu added a commit to sethlu/electron-packager that referenced this issue Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
3fd358b 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
electron/packager#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu referenced this issue in sethlu/electron-packager Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
3dcb2a2 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
maxogden#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu referenced this issue in sethlu/electron-packager Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
3efe32a 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
maxogden#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu referenced this issue in sethlu/electron-packager Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
3fd8096 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
maxogden#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu referenced this issue in sethlu/electron-packager Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
0808024 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
maxogden#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu referenced this issue in sethlu/electron-packager Feb 15, 2016
@sethlu
Mac App Store platform support + OS X platform improvements
061afb5 
- Added: platform `mas` for Mac App Store distribution
- Added: CFBundleIdentifier is now filtered, according to Apple
Documentation
- Fixed: CFBundleIdentifiers for Helper EH and Helper NP, to
maxogden#261
- Moved: `codesign` now with external `electron-osx-sign` module
sethlu added a commit to sethlu/electron-packager that referenced this issue Feb 16, 2016
@sethlu
Filter CFBundleIdentifier + set CFBundle properties
92a63a9 
Fix: ix electron/packager#261
Fix: electron/packager#163
Added filterCFBundleIdentifier function
Properties to set in app plist
- CFBundleDisplayName
- CFBundleIdentifier
- CFBundleName
Properties to set in helper plist
- CFBundleDisplayName
- CFBundleIdentifier
- CFBundleName
- CFBundleExecutable
In testing script:
- Added testing with special characters
malept added a commit that referenced this issue Feb 18, 2016
@malept
Merge pull request #223 from sethlu/master
3a64e65 
Platform: Mac App Store support

Fixes #104, #163, #261.
@malept
Copy link
Member

malept commented Feb 18, 2016

Fixed in #223.

@malept malept closed this as completed Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 build-target:mac 🍎 Bundling an Electron app specifically for macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malept @jasonhinkle