Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update requirements in readme #300

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

felixrieseberg
Copy link
Member

I discovered today that passing in designated requirements as a string did not work - whereas the exact same string in a text file did indeed work. This PR fixes that in our README.

Works:

osxSign: {
  identity: 'Developer ID Application: Felix Rieseberg (LT94ZKYDCJ)',
  optionsForFile: (filePath) => {
    entitlements: 'static/entitlements.plist',
    requirements: path.resolve(__dirname, 'tools/certs/requirements.txt'),
  },
}

Does not work:

osxSign: {
  identity: 'Developer ID Application: Felix Rieseberg (LT94ZKYDCJ)',
  optionsForFile: (filePath) => {
    entitlements: 'static/entitlements.plist',
    requirements: 'designated => anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and ( certificate leaf[subject.OU] = LT94ZKYDCJ or certificate leaf[subject.OU] = UY52UFTVTM )'
  },
}

@felixrieseberg felixrieseberg requested a review from a team as a code owner November 29, 2023 23:36
@felixrieseberg felixrieseberg merged commit 71f8c92 into main Nov 30, 2023
4 checks passed
@felixrieseberg felixrieseberg deleted the felixr-requirements-docs branch November 30, 2023 00:49
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants