Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update installation instructions #317

Merged
merged 2 commits into from
May 15, 2024
Merged

docs: update installation instructions #317

merged 2 commits into from
May 15, 2024

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented May 15, 2024 •
edited

  • Recommend installation as a dev dependency
  • Remove yarn instructions
  • Remove global install recommendations

@erickzhao erickzhao requested a review from a team as a code owner May 15, 2024 19:16
malept
malept reviewed May 15, 2024
View reviewed changes
README.md Show resolved Hide resolved
VerteDinde
VerteDinde approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree with Mark's note on clarifying the built in functionality

@erickzhao erickzhao merged commit fdab709 into main May 15, 2024
3 checks passed
@erickzhao erickzhao deleted the erickzhao-patch-1 branch May 15, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erickzhao @malept @VerteDinde @dsanders11