Skip to content

Commit

Permalink
chore!: remove NotarizeLegacyOptions and OsxNotarizeOptions types
Browse files Browse the repository at this point in the history
BREAKING CHANGE: remove `NotarizeLegacyOptions` and `OsxNotarizeOptions` types
  • Loading branch information
erikian committed Nov 5, 2023
1 parent c587127 commit 129c066
Showing 1 changed file with 2 additions and 14 deletions.
16 changes: 2 additions & 14 deletions src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,12 @@

import { CreateOptions as AsarOptions } from '@electron/asar';
import { ElectronDownloadRequestOptions as ElectronDownloadOptions } from '@electron/get';
import {
LegacyNotarizeCredentials,
NotaryToolCredentials,
TransporterOptions
} from '@electron/notarize/lib/types';
import { NotaryToolCredentials } from '@electron/notarize/lib/types';
import { SignOptions } from '@electron/osx-sign/dist/esm/types';
import type { makeUniversalApp } from '@electron/universal';

type MakeUniversalOpts = Parameters<typeof makeUniversalApp>[0]

type NotarizeLegacyOptions = LegacyNotarizeCredentials & TransporterOptions;

/**
* Bundles Electron-based application source code with a renamed/customized Electron executable and
* its supporting files into folders ready for distribution.
Expand Down Expand Up @@ -130,12 +124,6 @@ declare namespace electronPackager {
/** See the documentation for [`@electron/osx-sign`](https://npm.im/@electron/osx-sign#opts) for details. */
type OsxSignOptions = Omit<SignOptions, 'app' | 'binaries' | 'platform' | 'version'>;

/**
* See the documentation for [`@electron/notarize`](https://npm.im/@electron/notarize#method-notarizeopts-promisevoid)
* for details.
*/
type OsxNotarizeOptions = { tool: 'notarytool' } & NotaryToolCredentials;

/**
* See the documentation for [`@electron/universal`](https://github.com/electron/universal)
* for details.
Expand Down Expand Up @@ -476,7 +464,7 @@ declare namespace electronPackager {
*
* @category macOS
*/
osxNotarize?: OsxNotarizeOptions;
osxNotarize?: NotaryToolCredentials;
/**
* If present, signs macOS target apps when the host platform is macOS and Xcode is installed.
* When the value is `true`, pass default configuration to the signing module. See
Expand Down

0 comments on commit 129c066

Please sign in to comment.