New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what should final output be for Windows? #21
Comments
atom has both a |
Naturally the simple option is .zip support. It is also pretty straight forward to create a basic installer with a MakeNSIS configuration file (see example here: https://github.com/Aluxian/Facebook-Messenger-Desktop/blob/master/assets-windows/) but note that wouldn't give the auto-updating functionality found in the solution Atom uses. My current use case calls for using Squirrel (because I need the auto-updater and don't want to roll my own). We would need to either bundle or download a handful of the Squirrel binaries. You can see how Atom uses Squirrel to generate the installer here: https://github.com/atom/grunt-electron-installer |
is the .zip in option 1 a zip that has e.g. |
Yeah that's what it looks like, an exe file along with a handful of other dlls and misc files.
|
In the zip option, users would have to unzip it to a directory somewhere and then run the .exe from that location |
I am for an option between zip and raw folder. An installer doesn't make sense, I think it's out of the scope for electron-packager. This is a job for a new tool that creates an installer for Windows and a dmg for OS X? |
@Ivshti +1 that is a great point about scope On Sun, May 10, 2015 at 1:34 AM, Ivo Georgiev notifications@github.com
|
Just to throw in my two cents, I'm using this for creating packages currently and I love it. I agree with @Ivshti that installers are out of scope of this tool, but the only tool I am aware of (https://github.com/domderen/atom-shell-installer) doesn't work with a folder output from this tool (some complaint about name in the nuget packing process). So really looking for a CLI tool like this one that can create installer/dmg files for these apps for distribution. |
@englercj this is a tough thing. I've been packaging my app for almost a year now, and there are a few challenges I couldn't automate
My 2 cents, unless you're pushing new versions out every day, do the final step manually. It takes like 3 actions on OS X (replacing .app in the DMG) and 2-3 on Windows (pressing build on your installer creator). I am not trying to discourage you from automation though, I am just saying it's a nasty process to automate. For OS X - sure. For windows - if there's a way to build quality SFX installers under any platform - sure, but I haven't been able to find that. |
Could you please open an issue and include the specific error message? Thanks! |
thanks for the feedback everyone, I'm gonna close this for now but open a new issue to specifically discuss app packaging |
ok new issue to discuss installers is here: #33 |
@Ivshti how do you actually "press build on your installer creator"? Where do you find this option? I'd like to deliver a single .exe rather than a .zip with a bunch of dll's inside. |
Mac apps are conveniently distributed as folders, and the OS GUI treats them nicely as a single entity. On Windows (with #20) we end up as a folder, which is not a very natural way to distribute apps.
There's a couple of options I wanted to raise for discussion:
The text was updated successfully, but these errors were encountered: