Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing documentation about version-string option #447

Closed
albertvazquezm opened this issue Aug 11, 2016 · 2 comments
Closed

Confusing documentation about version-string option #447

albertvazquezm opened this issue Aug 11, 2016 · 2 comments
Labels
question ❓ Question about using Electron Packager. Not supported in this issue tracker.

Comments

@albertvazquezm
Copy link

albertvazquezm commented Aug 11, 2016

Hi,

In API documentation, params are kebab-case. Wich is not allowed in a javascript object. I can replace it by camelCase, but the exe description and product name is not updated and don't know if it's error about format or just a bug in electron-packager.

My config looks like: (some fields omitted)

let options = {
dir: './dist',
versionString: {
CompanyName: config.authors,
FileDescription: config.description,
OriginalFilename: config.title,
ProductName: config.title,
InternalName: config.title
}
};

And the exe gets that config:

First highlighted field is File Description and the second one is Product Name (Sorry for Spanish OS) :)

electron-exe-notupdating

Thanks!

@malept malept added the question ❓ Question about using Electron Packager. Not supported in this issue tracker. label Aug 11, 2016
@malept
Copy link
Member

malept commented Aug 11, 2016

"kebab-case" parameters are allowed in a JavaScript object, you just need to write them as strings, for example:

{
  "version-string": {
    ProductName: "My Product",
    // etc.
  }
}

Changing version-string to be more Object-friendly has been reported in #325 (and also #331).

@malept malept closed this as completed Aug 11, 2016
@albertvazquezm
Copy link
Author

It worked for me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question ❓ Question about using Electron Packager. Not supported in this issue tracker.
Projects
None yet
Development

No branches or pull requests

2 participants