Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename version-string parameter to win32metadata #331

Closed
malept opened this issue Apr 18, 2016 · 0 comments
Closed

Rename version-string parameter to win32metadata #331

malept opened this issue Apr 18, 2016 · 0 comments
Assignees
@malept
Labels
build-target:windows Bundling an Electron app specifically for Windows enhancement Feature request
Milestone
8.0.0

Comments

@malept
Copy link
Member

malept commented Apr 18, 2016

version-string is a platform-agnostic name, but it will really only be an OS-specific parameter. Plus, it's one of the parameters named un-idiomatically (#325). Renaming it will make it more obvious as to what the parameter is for.

This will need a minor version bump when win32metadata is added + version-string is deprecated, and a major version bump when version-string is removed.
@malept malept added enhancement Feature request help wanted Needs a contributor from the community build-target:windows Bundling an Electron app specifically for Windows labels Apr 18, 2016
@JimiC JimiC mentioned this issue Jun 2, 2016
Closed
@malept malept mentioned this issue Aug 11, 2016
Closed
@malept malept added this to the 8.0.0 milestone Aug 21, 2016
@malept malept removed the help wanted Needs a contributor from the community label Aug 21, 2016
@malept malept self-assigned this Aug 21, 2016
@malept malept mentioned this issue Aug 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malept malept

Labels
build-target:windows Bundling an Electron app specifically for Windows enhancement Feature request
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@malept