Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using yarn as package manager creates yarn.lock within app even when ignored #764

Closed
3 tasks done
jmquigley opened this issue Nov 29, 2017 · 2 comments
Closed
3 tasks done

Comments

@jmquigley
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Changing the package manager to use yarn reproduces the yarn.lock within the app output even when it is ignored. The --ignore will delete the original lock file, but it is then recreated during pruning when yarn install --production --no-bin-links is called in prune.js. Adding the option '--no-lockfile' to this cli call would prevent this behavior (I just modified my local copy of the app to try it). The lock file is not needed for runtime.

@welcome
Copy link

welcome bot commented Nov 29, 2017

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@malept
Copy link
Member

malept commented Nov 29, 2017

Thanks for catching this. FYI, I'm likely going to drop the --package-manager flag in the next major release (within the next several weeks) so even if I add --no-lockfile in the meantime, it's not going to hang around for much longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants