Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert from electron-download to @electron/get #1002

Merged
merged 3 commits into from Jun 13, 2019

Conversation

malept
Copy link
Member

@malept malept commented May 29, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

BREAKING CHANGE: The download options are completely different.

Depends on:

@malept
Copy link
Member Author

malept commented May 29, 2019

Blocked by electron/get#96

@malept
Copy link
Member Author

malept commented Jun 6, 2019

Basically need to update all the tests to use more recent versions of Electron. Will probably do that in a separate PR.

BREAKING CHANGE: The download options are completely different.
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #1002 into v14-develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v14-develop   #1002   +/-   ##
===========================================
  Coverage          100%    100%           
===========================================
  Files               13      13           
  Lines              677     677           
===========================================
  Hits               677     677
Impacted Files Coverage Δ
src/cli.js 100% <ø> (ø) ⬆️
src/download.js 100% <100%> (ø) ⬆️
src/targets.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab043e...d5b96ab. Read the comment docs.

@malept malept merged commit 086c28c into v14-develop Jun 13, 2019
@malept malept deleted the @electron/get branch June 13, 2019 22:53
malept added a commit that referenced this pull request Jun 20, 2019
BREAKING CHANGE: The download options are completely different.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant