Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rcedit to ^2.0.0 #1003

Merged
merged 1 commit into from
May 29, 2019
Merged

chore: upgrade rcedit to ^2.0.0 #1003

merged 1 commit into from
May 29, 2019

Conversation

malept
Copy link
Member

@malept malept commented May 29, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Upgrade to the promisified rcedit module.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1003 into v14-develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           v14-develop   #1003   +/-   ##
===========================================
  Coverage          100%    100%           
===========================================
  Files               13      13           
  Lines              675     674    -1     
===========================================
- Hits               675     674    -1
Impacted Files Coverage Δ
src/win32.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8103b9f...7a9dde0. Read the comment docs.

@malept malept merged commit c4b98dd into v14-develop May 29, 2019
@malept malept deleted the node-rcedit-2 branch May 29, 2019 15:28
malept added a commit that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant