Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor codesign testing #1010

Merged
merged 23 commits into from
Jun 5, 2019
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jun 5, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).

Summarize your changes:

Shamelessly copied from @MarshallOfSound's electron/electron#17668

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #1010 into v14-develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v14-develop   #1010   +/-   ##
===========================================
  Coverage          100%    100%           
===========================================
  Files               13      13           
  Lines              678     677    -1     
===========================================
- Hits               678     677    -1
Impacted Files Coverage Δ
src/mac.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99f4e9...d8a3ecc. Read the comment docs.

@malept malept merged commit 63f5a1d into v14-develop Jun 5, 2019
@malept malept deleted the refactor-codesign-testing branch June 5, 2019 21:11
malept added a commit that referenced this pull request Jun 20, 2019
* chore: test Travis/macOS with xcode10.1
* chore: copy codesign setup from electron/electron
* chore: only run codesign test on macOS hosts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant