Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: always test against post-1.0 versions of Electron #1012

Merged
merged 2 commits into from
Jun 8, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jun 8, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Use more recent and fewer versions of Electron in tests.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #1012 into v14-develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           v14-develop   #1012   +/-   ##
===========================================
  Coverage          100%    100%           
===========================================
  Files               13      13           
  Lines              677     677           
===========================================
  Hits               677     677

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ceda6...a074316. Read the comment docs.

@malept malept changed the title Always test against post-1.0 versions of Electron refactor: always test against post-1.0 versions of Electron Jun 8, 2019
@malept malept merged commit cab043e into v14-develop Jun 8, 2019
@malept malept deleted the support-modernish-electron-versions branch June 8, 2019 06:12
malept added a commit that referenced this pull request Jun 20, 2019
* chore: replace Electron 1.3.1 with 1.4.13 in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant