Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unzip): warn Windows 7 users of the unzip dependency #1030

Merged
merged 1 commit into from Jul 18, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jul 17, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Addresses #1029.

@russlamb
Copy link

warning is showing on build

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #1030 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1030   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          13      14    +1     
  Lines         677     687   +10     
======================================
+ Hits          677     687   +10
Impacted Files Coverage Δ
src/unzip.js 100% <100%> (ø)
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0df8d92...53f796e. Read the comment docs.

@malept malept merged commit 9a10b40 into master Jul 18, 2019
@malept malept deleted the warn-windows-7 branch July 18, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants