Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Electron v6 helpers #1033

Merged
merged 1 commit into from Jul 24, 2019
Merged

fix: support Electron v6 helpers #1033

merged 1 commit into from Jul 24, 2019

Conversation

MarshallOfSound
Copy link
Member

Adds support for the new Electron Helper (Renderer).app and Electron Helper (Plugin).app helper bundles 👍

@MarshallOfSound MarshallOfSound force-pushed the support-v6-helpers branch 2 times, most recently from 07aee10 to f13959a Compare July 24, 2019 21:00
malept
malept requested changes Jul 24, 2019
View reviewed changes
test/darwin.js Outdated Show resolved Hide resolved
test/darwin.js Show resolved Hide resolved
@malept malept merged commit 8d407e7 into master Jul 24, 2019
@MarshallOfSound MarshallOfSound deleted the support-v6-helpers branch July 24, 2019 21:29
@MarshallOfSound MarshallOfSound mentioned this pull request Jul 24, 2019
Closed
3 tasks
@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

19 similar comments
@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Jul 25, 2019 •
edited

Codecov Report

Merging #1033 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1033   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         687     687           
======================================
  Hits          687     687
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef6284...c2dbed8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @codecov-io @malept