Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usageDescription option for darwin/mas targets #1049

Merged
merged 3 commits into from Sep 25, 2019

Conversation

malept
Copy link
Member

@malept malept commented Sep 9, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a convenience option to set usage descriptions for the macOS store, on darwin/mas targets.

Reference: electron/electron#19871 (review)

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #1049 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files          14       14              
  Lines         695      699       +4     
==========================================
+ Hits          691      695       +4     
  Misses          4        4
Impacted Files Coverage Δ
src/mac.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce21c5d...fe5e03d. Read the comment docs.

@malept malept merged commit c3ad027 into master Sep 25, 2019
@malept malept deleted the usage-description branch September 25, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants