Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always initialize proxy support when running the CLI #1077

Merged
merged 1 commit into from Nov 19, 2019

Conversation

malept
Copy link
Member

@malept malept commented Nov 19, 2019

Summarize your changes:

Don't expect users to set the environment variable ELECTRON_GET_USE_PROXY=1 if they need to use a proxy.

@malept malept force-pushed the cli-always-has-proxy-support branch from b7bc0a5 to abdfab3 Compare November 19, 2019 22:10
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1077 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1077   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          14      14           
  Lines         694     695    +1     
======================================
+ Hits          694     695    +1
Impacted Files Coverage Δ
src/cli.js 100% <100%> (ø) ⬆️
src/unzip.js 100% <0%> (ø) ⬆️
src/ignore.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a572fb6...abdfab3. Read the comment docs.

@malept malept merged commit a4d9ce7 into master Nov 19, 2019
@malept malept deleted the cli-always-has-proxy-support branch November 19, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants