Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win32): correctly catch missing wine exceptions #1117

Merged
merged 1 commit into from Feb 7, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 7, 2020

Summarize your changes:

I noticed that the human-friendly message wasn't getting printed out on a Linux install sans wine.

@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #1117 into master will decrease coverage by 0.7%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage     100%   99.29%   -0.71%     
==========================================
  Files          14       14              
  Lines         712      712              
==========================================
- Hits          712      707       -5     
- Misses          0        5       +5
Impacted Files Coverage Δ
src/win32.js 100% <100%> (ø) ⬆️
src/mac.js 96.95% <0%> (-3.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d978bb8...e7cbed3. Read the comment docs.

@malept malept merged commit be9bbe5 into master Feb 7, 2020
@malept malept deleted the fix-rcedit-error-mutation branch February 7, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants